Filter expert: Docs fix, treat false as false for filter_regex and add logging #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-certat
approved these changes
Jul 3, 2024
| @@ -64,7 +64,7 @@ def init(self): | |||
| self.filter = False | |||
|
|
|||
| self.regex = False | |||
| if self.filter_regex is not None: | |||
| if self.filter_regex is not None and self.filter_regex is not False: | |||
There was a problem hiding this comment.
If this attribute is empty or evaluates to false
In such case, the if not self.filter_regex would be better
There was a problem hiding this comment.
yeah, right, that should cover more cases
There was a problem hiding this comment.
ok, no. this now triggers 10 test fails
sebix
force-pushed
the
filter-docs
branch
2 times, most recently
from
832534e
to
fdd209b
Compare
if the parameter filter_regex: false was set, the bot treated this as true with this patch, false is treated as false
if users or devs run the bot in DEBUG log level, there was no useful output yet. This change adds two log statements, showing which comparision was made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the parameter
with this patch, false is treated as false
if users or devs run the bot in DEBUG log level, there was no useful
output yet.
This change adds two log statements, showing which comparision was made